Enhance SyntaxLogicalInverter to handle CoalesceExpressions and add corresponding tests #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefpihrt
requested changes
Apr 14, 2023
| case SyntaxKind.CoalesceExpression: | ||
| { | ||
| var binaryExpression = (BinaryExpressionSyntax)expression; | ||
| if (binaryExpression.Right.Kind() == SyntaxKind.FalseLiteralExpression) |
Collaborator
There was a problem hiding this comment.
Please use IsKind instead of Kind. It is preferred in the codebase. It has also slightly better perf.
| if (binaryExpression.Right.Kind() == SyntaxKind.FalseLiteralExpression) | ||
| { | ||
| // !(x ?? false) === (x != true) | ||
| return BinaryExpression(SyntaxKind.NotEqualsExpression, binaryExpression.Left, LiteralExpression(SyntaxKind.TrueLiteralExpression)); |
Collaborator
There was a problem hiding this comment.
CSharpFactory provides some helper methods to make these calls shorter: CSharpFactory.NotEqualsExpression and CSharpFactory.TrueLiteralExpression.
josefpihrt
approved these changes
Apr 15, 2023
Collaborator
|
👍 |
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
…orresponding tests (dotnet#1069)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit handling of CoalesceExpressions in the SyntaxLogicalInverter class. Currently, in Debug mode the Debug.Fail on L213 will be evaluated which is a less-than-ideal experience.
This PR also adds intelligent support for the case where the RHS of the coalesce operator is either true or false.
x??trueis inverted tox==falsex??falseis inverted tox!=true